Add class for custom transforms to adapter, similar to LambdaTransform.
#399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit reintroduces the features that were present in `LambdaTransform`, but only allowing registered functions. While being stricter, that allows for closer scaffolding and raising errors early on, so that users cannot provide functions that will not be (de)serializable later on. As there are a few failure modes, the focus is on providing detailed error messages to enable users to solve problems without external help.
Codecov ReportAttention: Patch coverage is
|
LarsKue
requested changes
Apr 11, 2025
Contributor
LarsKue
left a comment
LarsKue
left a comment
There was a problem hiding this comment.
Very awesome changes, thank you for covering this so thoroughly!
I do see the need for some minor changes, particularly in the tests. See individual comments.
Collaborator
Author
|
Thanks a lot for the review, I have addressed your comments. The tests are currently failing because I pulled in the changes from |
Contributor
|
@vpratz Yes, dev is now fixed. Can you please merge dev into this again and if tests pass, merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #362.
This PR reintroduces the features that were present in
LambdaTransform, but only allowing registered functions. While being stricter, this allows for closer scaffolding and raising errors early on, so that users cannot provide functions that will not be (de)serializable later on.As there are a few failure modes, the focus is on providing detailed error messages to enable users to solve problems without external help.
Open questions:
serializable_forward/inverse_fntoforward/inverseagain. What do you think?Adapter, as it helps in easily providing the user with theFilterTransformfunctionality. Is this ok with you, @LarsKue